Швороб. Task №6 - #1
Open
shvorobsofia wants to merge 22 commits into
Open
Conversation
…: preorder, postorder, insert_node, remove, split, merge, find.
Krekep
requested changes
Nov 15, 2024
Krekep
left a comment
Krekep
left a comment
Collaborator
There was a problem hiding this comment.
По самому заданию вопросов нет, но надо провести облагораживание кода
Comment on lines
+5
to
+10
| branches: | ||
| - task_6 | ||
| pull_request: | ||
| branches: | ||
| - task_6 | ||
| - main |
Collaborator
There was a problem hiding this comment.
Лучше запускать CI не на конкретных ветках, а как в code_style.yml
on:
# Triggers the workflow on push or pull request events
[ push, pull_request ]
Collaborator
There was a problem hiding this comment.
Не хватает настроенного CI для статической проверки типов с помощью mypy
Collaborator
There was a problem hiding this comment.
test_basic стоит удалить и тесты для каждого модуля писать в отдельном файле
Collaborator
There was a problem hiding this comment.
Также добавьте тест, проверяющий работу оператора in
Owner
Author
There was a problem hiding this comment.
Разделила тесты по функциональности по разным файлам. Добавила тест для оператора in
Krekep
requested changes
Apr 8, 2025
Krekep
left a comment
Krekep
left a comment
Collaborator
There was a problem hiding this comment.
Не хватает typehint в классе Treap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a realization of treap.
Were implemented: